diff options
| author | Heiner Kallweit <hkallweit1@gmail.com> | 2023-11-23 12:53:26 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-11-24 18:27:22 +0300 |
| commit | 3a767b482cacd9bfeac786837fcac419af315995 (patch) | |
| tree | 36d525139e01d617a0e479a02fa5bbf743059842 /drivers/net/ethernet/realtek/r8169_firmware.c | |
| parent | 30c90200153430915a4c4aaaca7437d2592e6ed2 (diff) | |
| download | linux-3a767b482cacd9bfeac786837fcac419af315995.tar.xz | |
r8169: remove not needed check in rtl_fw_write_firmware
This check can never be true for a firmware file with a correct format.
Existing checks in rtl_fw_data_ok() are sufficient, no problems with
invalid firmware files are known.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/realtek/r8169_firmware.c')
| -rw-r--r-- | drivers/net/ethernet/realtek/r8169_firmware.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/ethernet/realtek/r8169_firmware.c b/drivers/net/ethernet/realtek/r8169_firmware.c index cbc6b846ded5..ed6e721b1555 100644 --- a/drivers/net/ethernet/realtek/r8169_firmware.c +++ b/drivers/net/ethernet/realtek/r8169_firmware.c @@ -151,9 +151,6 @@ void rtl_fw_write_firmware(struct rtl8169_private *tp, struct rtl_fw *rtl_fw) u32 regno = (action & 0x0fff0000) >> 16; enum rtl_fw_opcode opcode = action >> 28; - if (!action) - break; - switch (opcode) { case PHY_READ: predata = fw_read(tp, regno); |