diff options
author | Claudiu Beznea <claudiu.beznea@microchip.com> | 2022-01-18 14:08:12 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2022-01-19 17:23:34 +0300 |
commit | f1131b9c23fb4a3540a774828ff49f421619f902 (patch) | |
tree | 99b493b5739289683de465ed06a41de47f30436b /drivers/net/ethernet/mscc/ocelot_flower.c | |
parent | 1771afd47430f5e95c9c3a2e3a8a63e67402d3fe (diff) | |
download | linux-f1131b9c23fb4a3540a774828ff49f421619f902.tar.xz |
net: phy: micrel: use kszphy_suspend()/kszphy_resume for irq aware devices
On a setup with KSZ9131 and MACB drivers it happens on suspend path, from
time to time, that the PHY interrupt arrives after PHY and MACB were
suspended (PHY via genphy_suspend(), MACB via macb_suspend()). In this
case the phy_read() at the beginning of kszphy_handle_interrupt() will
fail (as MACB driver is suspended at this time) leading to phy_error()
being called and a stack trace being displayed on console. To solve this
.suspend/.resume functions for all KSZ devices implementing
.handle_interrupt were replaced with kszphy_suspend()/kszphy_resume()
which disable/enable interrupt before/after calling
genphy_suspend()/genphy_resume().
The fix has been adapted for all KSZ devices which implements
.handle_interrupt but it has been tested only on KSZ9131.
Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/mscc/ocelot_flower.c')
0 files changed, 0 insertions, 0 deletions