diff options
| author | Xiongfeng Wang <xiongfeng.wang@linaro.org> | 2018-01-08 15:40:59 +0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2018-02-26 14:58:40 +0300 |
| commit | 81b9de43599c59a3d5bd3e6e8645cb20b87840bc (patch) | |
| tree | bb62afe401f29c2f8ce86b9402ab586393f676d7 /drivers/media/media-device.c | |
| parent | 664878184f831c87031988a03078cb7bc0a990d2 (diff) | |
| download | linux-81b9de43599c59a3d5bd3e6e8645cb20b87840bc.tar.xz | |
media: media-device: use strlcpy() instead of strncpy()
gcc-8 reports
drivers/media/media-device.c: In function 'media_device_get_topology':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
bound 64 equals destination size [-Wstringop-truncation]
We need to use strlcpy() to make sure the dest string is nul-terminated.
Signed-off-by: Xiongfeng Wang <xiongfeng.wang@linaro.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/media-device.c')
| -rw-r--r-- | drivers/media/media-device.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index e79f72b8b858..f44244415124 100644 --- a/drivers/media/media-device.c +++ b/drivers/media/media-device.c @@ -255,7 +255,7 @@ static long media_device_get_topology(struct media_device *mdev, memset(&kentity, 0, sizeof(kentity)); kentity.id = entity->graph_obj.id; kentity.function = entity->function; - strncpy(kentity.name, entity->name, + strlcpy(kentity.name, entity->name, sizeof(kentity.name)); if (copy_to_user(uentity, &kentity, sizeof(kentity))) |