summaryrefslogtreecommitdiff
path: root/drivers/macintosh
diff options
context:
space:
mode:
authorLuis Felipe Hernandez <luis.hernandez093@gmail.com>2024-12-18 05:55:41 +0300
committerMadhavan Srinivasan <maddy@linux.ibm.com>2024-12-18 11:11:23 +0300
commite834166822a3c9fb403411c898367df8dabf973c (patch)
tree6f051fb4669f07570ddafafd221ebbb6b403a404 /drivers/macintosh
parent65f5038352e8f635fb827f7482f1d08fae4d16bf (diff)
downloadlinux-e834166822a3c9fb403411c898367df8dabf973c.tar.xz
macintosh: declare ctl_table as const
Since commit 7abc9b53bd51 ("sysctl: allow registration of const struct ctl_table"), the sysctl registration API allows struct ctl_table variables to be placed into read-only memory. mac_hid_files is registered as a sysctl table and should be treated as read-only. By declaring the mac_hid_files structure as const, we ensure that it cannot be accidentally modified. This change improves safety. Suggested-by: Thomas Weißschuh <linux@weissschuh.net> Suggested-by: Ricardo B. Marliere <rbm@suse.com> Reviewed-by: Ricardo B. Marliere <rbm@suse.com> Signed-off-by: Luis Felipe Hernandez <luis.hernandez093@gmail.com> Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com> Link: https://patch.msgid.link/20241217-constify_ctl_table-v1-1-402ebceaeb8e@gmail.com
Diffstat (limited to 'drivers/macintosh')
-rw-r--r--drivers/macintosh/mac_hid.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/macintosh/mac_hid.c b/drivers/macintosh/mac_hid.c
index b461b1bed25b..369d72f59b3c 100644
--- a/drivers/macintosh/mac_hid.c
+++ b/drivers/macintosh/mac_hid.c
@@ -215,7 +215,7 @@ static int mac_hid_toggle_emumouse(const struct ctl_table *table, int write,
}
/* file(s) in /proc/sys/dev/mac_hid */
-static struct ctl_table mac_hid_files[] = {
+static const struct ctl_table mac_hid_files[] = {
{
.procname = "mouse_button_emulation",
.data = &mouse_emulate_buttons,