diff options
author | Marek BehĂșn <kabel@kernel.org> | 2023-09-18 19:11:01 +0300 |
---|---|---|
committer | Lee Jones <lee@kernel.org> | 2023-11-01 14:28:43 +0300 |
commit | 6de283b96b31b4890e3ee8c86caca2a3a30d1011 (patch) | |
tree | c0277cf90e5bca8039b49b62e019fbf16ff1554c /drivers/leds/leds-ot200.c | |
parent | 7c977019c53ed2689e5509ebd1d89a424cf3d313 (diff) | |
download | linux-6de283b96b31b4890e3ee8c86caca2a3a30d1011.tar.xz |
leds: turris-omnia: Do not use SMBUS calls
The leds-turris-omnia driver uses three function for I2C access:
- i2c_smbus_write_byte_data() and i2c_smbus_read_byte_data(), which
cause an emulated SMBUS transfer,
- i2c_master_send(), which causes an ordinary I2C transfer.
The Turris Omnia MCU LED controller is not semantically SMBUS, it
operates as a simple I2C bus. It does not implement any of the SMBUS
specific features, like PEC, or procedure calls, or anything. Moreover
the I2C controller driver also does not implement SMBUS, and so the
emulated SMBUS procedure from drivers/i2c/i2c-core-smbus.c is used for
the SMBUS calls, which gives an unnecessary overhead.
When I first wrote the driver, I was unaware of these facts, and I
simply used the first function that worked.
Drop the I2C SMBUS calls and instead use simple I2C transfers.
Fixes: 089381b27abe ("leds: initial support for Turris Omnia LEDs")
Signed-off-by: Marek BehĂșn <kabel@kernel.org>
Link: https://lore.kernel.org/r/20230918161104.20860-2-kabel@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
Diffstat (limited to 'drivers/leds/leds-ot200.c')
0 files changed, 0 insertions, 0 deletions