diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2012-11-27 11:24:00 +0400 |
|---|---|---|
| committer | Jonathan Cameron <jic23@kernel.org> | 2012-11-30 17:09:22 +0400 |
| commit | 12660138b491b56d1e70333547912c56741be5e8 (patch) | |
| tree | 321742511bde3e748bb986f81300fc002d7834bf /drivers/iio/gyro/adis16136.c | |
| parent | bc0a409c5ffd91b5403037ab2798b84dccee4f06 (diff) | |
| download | linux-12660138b491b56d1e70333547912c56741be5e8.tar.xz | |
iio:gyro: adis16136: divide by zero in write_frequency()
It's slightly cleaner to use kstrtouint() because we pass unsigned ints
to adis16136_set_freq(). On 64 bit systems, if the user passed LONG_MIN
then it we would get past the test against zero but crash in
adis16136_set_freq() because we truncate the high bits away.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-By: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Diffstat (limited to 'drivers/iio/gyro/adis16136.c')
| -rw-r--r-- | drivers/iio/gyro/adis16136.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/iio/gyro/adis16136.c b/drivers/iio/gyro/adis16136.c index 05486dfd721b..b4ee3393b772 100644 --- a/drivers/iio/gyro/adis16136.c +++ b/drivers/iio/gyro/adis16136.c @@ -203,10 +203,10 @@ static ssize_t adis16136_write_frequency(struct device *dev, { struct iio_dev *indio_dev = dev_to_iio_dev(dev); struct adis16136 *adis16136 = iio_priv(indio_dev); - long val; + unsigned int val; int ret; - ret = kstrtol(buf, 10, &val); + ret = kstrtouint(buf, 10, &val); if (ret) return ret; |