diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2024-07-14 00:26:19 +0300 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2024-07-14 21:48:50 +0300 |
| commit | cbf7467828cd4ec7ceac7a8b5b5ddb2f69f07b0e (patch) | |
| tree | ea3f27fe8bc3ff750d7310cbab1af9d7fdc1f058 /drivers/hwmon | |
| parent | ed99ae74f2328e42286880c946953a8f9dd95a7e (diff) | |
| download | linux-cbf7467828cd4ec7ceac7a8b5b5ddb2f69f07b0e.tar.xz | |
hwmon: (max6697) Fix underflow when writing limit attributes
Using DIV_ROUND_CLOSEST() on an unbound value can result in underflows.
Indeed, module test scripts report:
temp1_max: Suspected underflow: [min=0, read 255000, written -9223372036854775808]
temp1_crit: Suspected underflow: [min=0, read 255000, written -9223372036854775808]
Fix by introducing an extra set of clamping.
Fixes: 5372d2d71c46 ("hwmon: Driver for Maxim MAX6697 and compatibles")
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/max6697.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hwmon/max6697.c b/drivers/hwmon/max6697.c index b28b7b9448aa..05085646ba99 100644 --- a/drivers/hwmon/max6697.c +++ b/drivers/hwmon/max6697.c @@ -311,6 +311,7 @@ static ssize_t temp_store(struct device *dev, return ret; mutex_lock(&data->update_lock); + temp = clamp_val(temp, -1000000, 1000000); /* prevent underflow */ temp = DIV_ROUND_CLOSEST(temp, 1000) + data->temp_offset; temp = clamp_val(temp, 0, data->type == max6581 ? 255 : 127); data->temp[nr][index] = temp; |