diff options
| author | Sudeep Holla <sudeep.holla@arm.com> | 2018-03-15 19:54:18 +0300 |
|---|---|---|
| committer | Sudeep Holla <sudeep.holla@arm.com> | 2018-03-20 15:13:48 +0300 |
| commit | c09880cef78d0ddf149cdfeb733027a806465ba2 (patch) | |
| tree | 6927b1cf35b6754e99d46654263ee322430110b1 /drivers/hwmon | |
| parent | 02f208c5c60549039445402505dea284e15f0f4f (diff) | |
| download | linux-c09880cef78d0ddf149cdfeb733027a806465ba2.tar.xz | |
hwmon: (scmi) return -EINVAL when sensor information is unavailable
Passing NULL pointer to PTR_ERR will result in return value of 0
indicating success which is clearly not what it is intended here.
This patch returns -EINVAL instead when the sensor information is not
available.
Fixes: b23688aefb8b ("hwmon: add support for sensors exported via ARM SCMI")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/scmi-hwmon.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c index 32e750373ced..363bf56eb0f2 100644 --- a/drivers/hwmon/scmi-hwmon.c +++ b/drivers/hwmon/scmi-hwmon.c @@ -138,7 +138,7 @@ static int scmi_hwmon_probe(struct scmi_device *sdev) for (i = 0; i < nr_sensors; i++) { sensor = handle->sensor_ops->info_get(handle, i); if (!sensor) - return PTR_ERR(sensor); + return -EINVAL; switch (sensor->type) { case TEMPERATURE_C: |