diff options
| author | Tomáš Pecka <tomas.pecka@cesnet.cz> | 2023-04-20 20:19:39 +0300 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2023-04-21 17:27:23 +0300 |
| commit | 93822f5161a2dc57a60b95b35b3cb8589f53413e (patch) | |
| tree | 7d22a6109696eba44f977afdfdeb2c4f0271c19d /drivers/hwmon | |
| parent | 2a8e41ad337508fc5d598c0f9288890214f8e318 (diff) | |
| download | linux-93822f5161a2dc57a60b95b35b3cb8589f53413e.tar.xz | |
hwmon: (pmbus/fsp-3y) Fix functionality bitmask in FSP-3Y YM-2151E
The bit flags in pmbus_driver_info functionality for YM-2151E chip were
joined with a comma operator instead of a bitwise OR. This means that
the last constant PMBUS_HAVE_IIN was not OR-ed with the other
PM_BUS_HAVE_* constants for this page but it initialized the next element
of the func array (which was not accessed from anywhere because of the
number of pages).
However, there is no need for setting PMBUS_HAVE_IIN in the 5Vsb page
because this command does not seem to be paged. Obviously, the device
only has one IIN sensor, so it doesn't make sense to query it again from
the second page.
Fixes: 1734b4135a62 ("hwmon: Add driver for fsp-3y PSUs and PDUs")
Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz>
Signed-off-by: Tomáš Pecka <tomas.pecka@cesnet.cz>
Link: https://lore.kernel.org/r/20230420171939.212040-1-tomas.pecka@cesnet.cz
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/pmbus/fsp-3y.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/hwmon/pmbus/fsp-3y.c b/drivers/hwmon/pmbus/fsp-3y.c index aec294cc72d1..c7469d2cdedc 100644 --- a/drivers/hwmon/pmbus/fsp-3y.c +++ b/drivers/hwmon/pmbus/fsp-3y.c @@ -180,7 +180,6 @@ static struct pmbus_driver_info fsp3y_info[] = { PMBUS_HAVE_FAN12, .func[YM2151_PAGE_5VSB_LOG] = PMBUS_HAVE_VOUT | PMBUS_HAVE_IOUT, - PMBUS_HAVE_IIN, .read_word_data = fsp3y_read_word_data, .read_byte_data = fsp3y_read_byte_data, }, |