diff options
| author | Rhys Lloyd <krakow20@gmail.com> | 2025-07-18 10:36:25 +0300 |
|---|---|---|
| committer | Alexandre Courbot <acourbot@nvidia.com> | 2025-08-12 03:58:23 +0300 |
| commit | 2872c8982c80e22f9a7fc4db7d8f0e8188ab4cd7 (patch) | |
| tree | 6ce6d16dbd6aaa2a0daa4ba431821db8729f5566 /drivers/gpu/nova-core | |
| parent | 0f85b6c1cb5746180b2bf674a436a48e6722e7ed (diff) | |
| download | linux-2872c8982c80e22f9a7fc4db7d8f0e8188ab4cd7.tar.xz | |
gpu: nova-core: vbios: change PmuLookupTableEntry to use size_of
Annotate the PmuLookupTableEntry with an `#[repr(C, packed)]` attribute.
Removes another magic number by making the struct the same size as the
data it needs to read, allowing the use of
`size_of::<PmuLookupTableEntry>()`
[acourbot@nvidia.com: remove `dead_code` expect to fix `unfulfilled_lint_expectations` lint]
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Rhys Lloyd <krakow20@gmail.com>
Link: https://lore.kernel.org/r/20250718073633.194032-3-krakow20@gmail.com
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Diffstat (limited to 'drivers/gpu/nova-core')
| -rw-r--r-- | drivers/gpu/nova-core/vbios.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/nova-core/vbios.rs b/drivers/gpu/nova-core/vbios.rs index b4bca1919d8f..50fbea69fc00 100644 --- a/drivers/gpu/nova-core/vbios.rs +++ b/drivers/gpu/nova-core/vbios.rs @@ -892,7 +892,7 @@ impl TryFrom<BiosImageBase> for PciAtBiosImage { /// The [`PmuLookupTableEntry`] structure is a single entry in the [`PmuLookupTable`]. /// /// See the [`PmuLookupTable`] description for more information. -#[expect(dead_code)] +#[repr(C, packed)] struct PmuLookupTableEntry { application_id: u8, target_id: u8, @@ -901,7 +901,7 @@ struct PmuLookupTableEntry { impl PmuLookupTableEntry { fn new(data: &[u8]) -> Result<Self> { - if data.len() < 6 { + if data.len() < core::mem::size_of::<Self>() { return Err(EINVAL); } |