diff options
| author | Krzysztof Kozlowski <krzk@kernel.org> | 2019-06-21 19:21:15 +0300 |
|---|---|---|
| committer | Qiang Yu <yuq825@gmail.com> | 2019-06-23 06:23:02 +0300 |
| commit | 34e88f9e2fff2d46a206e4d94c9e8fdf45b85d9a (patch) | |
| tree | aff0300cba05ef87c87b4c98c37dd9a07266bd74 /drivers/gpu/drm/lima/lima_drv.c | |
| parent | adbb48bcf4002fdf0901b936bd75db21bca8f514 (diff) | |
| download | linux-34e88f9e2fff2d46a206e4d94c9e8fdf45b85d9a.tar.xz | |
drm/lima: Reduce the amount of logs on deferred probe
There is no point to print deferred probe (and its failures to get
resources) as an error. For example getting a regulator causes three
unneeded error messages:
lima 13000000.gpu: failed to get regulator: -517
lima 13000000.gpu: regulator init fail -517
lima 13000000.gpu: Fatal error during GPU init
Also do not print clock rates before the initialization finishes
because they will be duplicated after deferral. Each probe step already
prints error so remove the final error message "Fatal error during GPU
init".
In case of multiple probe tries this would pollute the dmesg.
Fixes: a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190621162117.22533-2-krzk@kernel.org
Diffstat (limited to 'drivers/gpu/drm/lima/lima_drv.c')
| -rw-r--r-- | drivers/gpu/drm/lima/lima_drv.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/gpu/drm/lima/lima_drv.c b/drivers/gpu/drm/lima/lima_drv.c index beb10bc1a7f3..557bd1e1dffe 100644 --- a/drivers/gpu/drm/lima/lima_drv.c +++ b/drivers/gpu/drm/lima/lima_drv.c @@ -307,10 +307,8 @@ static int lima_pdev_probe(struct platform_device *pdev) ldev->ddev = ddev; err = lima_device_init(ldev); - if (err) { - dev_err(&pdev->dev, "Fatal error during GPU init\n"); + if (err) goto err_out1; - } /* * Register the DRM device with the core and the connectors with |