diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2022-01-15 10:40:47 +0300 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2022-02-15 14:23:11 +0300 |
| commit | 7326bf800a47e5dabf574abe48dc7d6aa95ee7a2 (patch) | |
| tree | f0d16867ec5b847e5d2572705e2ea148c94130a2 /drivers/dma/altera-msgdma.c | |
| parent | 728f6c783313fc789197837dce1f97d1f930cafe (diff) | |
| download | linux-7326bf800a47e5dabf574abe48dc7d6aa95ee7a2.tar.xz | |
dmaengine: altera-msgdma: Remove useless DMA-32 fallback configuration
As stated in [1], dma_set_mask() with a 64-bit mask never fails if
dev->dma_mask is non-NULL.
So, if it fails, the 32 bits case will also fail for the same reason.
Simplify code and remove some dead code accordingly.
[1]: https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@infradead.org/#t
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Stefan Roese <sr@denx.de>
Acked-by: Olivier Dautricourt <olivier.dautricourt@orolia.com>
Link: https://lore.kernel.org/r/01058ada3a0dea207212182ca7525060a204f1e1.1642232423.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/altera-msgdma.c')
| -rw-r--r-- | drivers/dma/altera-msgdma.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c index f5b885d69cd3..6f56dfd375e3 100644 --- a/drivers/dma/altera-msgdma.c +++ b/drivers/dma/altera-msgdma.c @@ -891,9 +891,7 @@ static int msgdma_probe(struct platform_device *pdev) ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); if (ret) { dev_warn(&pdev->dev, "unable to set coherent mask to 64"); - ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); - if (ret) - goto fail; + goto fail; } msgdma_reset(mdev); |