summaryrefslogtreecommitdiff
path: root/drivers/base
diff options
context:
space:
mode:
authorJack Pham <jackp@codeaurora.org>2016-04-15 09:37:26 +0300
committerBen Hutchings <ben@decadent.org.uk>2016-06-15 23:29:24 +0300
commit4c6ecde080ae0f1ff6d8ac3e6745ea72e54d5b8f (patch)
tree060aab2280fcb33d361979c96046ea07399ab151 /drivers/base
parentd6db3a73d106fdb0eacdecec6be98cb15f1e07bc (diff)
downloadlinux-4c6ecde080ae0f1ff6d8ac3e6745ea72e54d5b8f.tar.xz
regmap: spmi: Fix regmap_spmi_ext_read in multi-byte case
commit dec8e8f6e6504aa3496c0f7cc10c756bb0e10f44 upstream. Specifically for the case of reads that use the Extended Register Read Long command, a multi-byte read operation is broken up into 8-byte chunks. However the call to spmi_ext_register_readl() is incorrectly passing 'val_size', which if greater than 8 will always fail. The argument should instead be 'len'. Fixes: c9afbb05a9ff ("regmap: spmi: support base and extended register spaces") Signed-off-by: Jack Pham <jackp@codeaurora.org> Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers/base')
-rw-r--r--drivers/base/regmap/regmap-spmi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/base/regmap/regmap-spmi.c b/drivers/base/regmap/regmap-spmi.c
index d7026dc33388..b394aaef3867 100644
--- a/drivers/base/regmap/regmap-spmi.c
+++ b/drivers/base/regmap/regmap-spmi.c
@@ -153,7 +153,7 @@ static int regmap_spmi_ext_read(void *context,
while (val_size) {
len = min_t(size_t, val_size, 8);
- err = spmi_ext_register_readl(context, addr, val, val_size);
+ err = spmi_ext_register_readl(context, addr, val, len);
if (err)
goto err_out;