diff options
| author | Zijun Hu <quic_zijuhu@quicinc.com> | 2024-08-24 12:07:43 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-09-03 14:14:59 +0300 |
| commit | 903c44939abc02e2f3d6f2ad65fa090f7e5df5b6 (patch) | |
| tree | 7620f0aa2d4c00ff71df018067bd46753d07a475 /drivers/base/core.c | |
| parent | 8ab0f4605d5ce3c0d386b3828b07719f1e8e0505 (diff) | |
| download | linux-903c44939abc02e2f3d6f2ad65fa090f7e5df5b6.tar.xz | |
driver core: Make parameter check consistent for API cluster device_(for_each|find)_child()
The following API cluster takes the same type parameter list, but do not
have consistent parameter check as shown below.
device_for_each_child(struct device *parent, ...) // check (!parent->p)
device_for_each_child_reverse(struct device *parent, ...) // same as above
device_find_child(struct device *parent, ...) // check (!parent)
Fixed by using consistent check (!parent || !parent->p) which covers
both existing checks for the cluster.
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20240824-const_dfc_prepare-v3-1-32127ea32bba@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/base/core.c')
| -rw-r--r-- | drivers/base/core.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/base/core.c b/drivers/base/core.c index 6113bc1092ae..b69b82da8837 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -3998,7 +3998,7 @@ int device_for_each_child(struct device *parent, void *data, struct device *child; int error = 0; - if (!parent->p) + if (!parent || !parent->p) return 0; klist_iter_init(&parent->p->klist_children, &i); @@ -4028,7 +4028,7 @@ int device_for_each_child_reverse(struct device *parent, void *data, struct device *child; int error = 0; - if (!parent->p) + if (!parent || !parent->p) return 0; klist_iter_init(&parent->p->klist_children, &i); @@ -4062,7 +4062,7 @@ struct device *device_find_child(struct device *parent, void *data, struct klist_iter i; struct device *child; - if (!parent) + if (!parent || !parent->p) return NULL; klist_iter_init(&parent->p->klist_children, &i); |