summaryrefslogtreecommitdiff
path: root/crypto
diff options
context:
space:
mode:
authorHui Tang <tanghui20@huawei.com>2021-05-22 05:44:29 +0300
committerHerbert Xu <herbert@gondor.apana.org.au>2021-05-28 10:11:47 +0300
commit8fd28fa5046b377039d5bbc0ab2f625dec703980 (patch)
tree2c8579a49ead01f345570dc964e9a3c547e95f0e /crypto
parent6889fc2104e5d20899b91e61daf07a7524b2010d (diff)
downloadlinux-8fd28fa5046b377039d5bbc0ab2f625dec703980.tar.xz
crypto: ecdh - fix 'ecdh_init'
NIST P192 is not unregistered if failed to register NIST P256, actually it need to unregister the algorithms already registered. Signed-off-by: Hui Tang <tanghui20@huawei.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto')
-rw-r--r--crypto/ecdh.c11
1 files changed, 10 insertions, 1 deletions
diff --git a/crypto/ecdh.c b/crypto/ecdh.c
index 197467509323..b6f493e82812 100644
--- a/crypto/ecdh.c
+++ b/crypto/ecdh.c
@@ -183,7 +183,16 @@ static int ecdh_init(void)
ret = crypto_register_kpp(&ecdh_nist_p192);
ecdh_nist_p192_registered = ret == 0;
- return crypto_register_kpp(&ecdh_nist_p256);
+ ret = crypto_register_kpp(&ecdh_nist_p256);
+ if (ret)
+ goto nist_p256_error;
+
+ return 0;
+
+nist_p256_error:
+ if (ecdh_nist_p192_registered)
+ crypto_unregister_kpp(&ecdh_nist_p192);
+ return ret;
}
static void ecdh_exit(void)