diff options
author | Will Deacon <will.deacon@arm.com> | 2018-11-08 01:58:24 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-02-12 21:47:07 +0300 |
commit | 710e1e561630975f934214c0196133fa12a86514 (patch) | |
tree | 8454dc5dd0cf0f98ac81fbcebdb2d23057fce6a4 /certs/system_certificates.S | |
parent | 61010bd9811d557124145e05d2f5993fca3c2484 (diff) | |
download | linux-710e1e561630975f934214c0196133fa12a86514.tar.xz |
iommu/arm-smmu-v3: Use explicit mb() when moving cons pointer
[ Upstream commit a868e8530441286342f90c1fd9c5f24de3aa2880 ]
After removing an entry from a queue (e.g. reading an event in
arm_smmu_evtq_thread()) it is necessary to advance the MMIO consumer
pointer to free the queue slot back to the SMMU. A memory barrier is
required here so that all reads targetting the queue entry have
completed before the consumer pointer is updated.
The implementation of queue_inc_cons() relies on a writel() to complete
the previous reads, but this is incorrect because writel() is only
guaranteed to complete prior writes. This patch replaces the call to
writel() with an mb(); writel_relaxed() sequence, which gives us the
read->write ordering which we require.
Cc: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'certs/system_certificates.S')
0 files changed, 0 insertions, 0 deletions