diff options
author | Janis Schoetterl-Glausch <scgl@linux.ibm.com> | 2022-03-11 20:00:40 +0300 |
---|---|---|
committer | Heiko Carstens <hca@linux.ibm.com> | 2022-05-02 20:45:03 +0300 |
commit | b5d1274409d0eec6d826f65d6dafebf9d77a1b99 (patch) | |
tree | 625cd38eba44cc56d11b7360690ad83feed99af6 /arch/s390/mm | |
parent | 8b202ee218395319aec1ef44f72043e1fbaccdd6 (diff) | |
download | linux-b5d1274409d0eec6d826f65d6dafebf9d77a1b99.tar.xz |
KVM: s390: Fix lockdep issue in vm memop
Issuing a memop on a protected vm does not make sense,
neither is the memory readable/writable, nor does it make sense to check
storage keys. This is why the ioctl will return -EINVAL when it detects
the vm to be protected. However, in order to ensure that the vm cannot
become protected during the memop, the kvm->lock would need to be taken
for the duration of the ioctl. This is also required because
kvm_s390_pv_is_protected asserts that the lock must be held.
Instead, don't try to prevent this. If user space enables secure
execution concurrently with a memop it must accecpt the possibility of
the memop failing.
Still check if the vm is currently protected, but without locking and
consider it a heuristic.
Fixes: ef11c9463ae0 ("KVM: s390: Add vm IOCTL for key checked guest absolute memory access")
Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Link: https://lore.kernel.org/r/20220322153204.2637400-1-scgl@linux.ibm.com
Signed-off-by: Christian Borntraeger <borntraeger@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Diffstat (limited to 'arch/s390/mm')
0 files changed, 0 insertions, 0 deletions