diff options
| author | Evgeniy Polyakov <johnpol@2ka.mipt.ru> | 2007-08-25 10:36:29 +0400 |
|---|---|---|
| committer | David S. Miller <davem@sunset.davemloft.net> | 2007-08-27 05:35:47 +0400 |
| commit | e7c243c925f6d9dcb898504ff24d6650b5cbb3b1 (patch) | |
| tree | f06ae59e206e4876b0326c65811f496a8b1f4bdc /MAINTAINERS | |
| parent | 7c8347a91dbbb723d8ed106ec817dabac97f2bbc (diff) | |
| download | linux-e7c243c925f6d9dcb898504ff24d6650b5cbb3b1.tar.xz | |
[VLAN/BRIDGE]: Fix "skb_pull_rcsum - Fatal exception in interrupt"
I tried to preserve bridging code as it was before, but logic is quite
strange - I think we should free skb on error, since it is already
unshared and thus will just leak.
Herbert Xu states:
> + if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL)
> + goto out;
If this happens it'll be a double-free on skb since we'll
return NF_DROP which makes the caller free it too.
We could return NF_STOLEN to prevent that but I'm not sure
whether that's correct netfilter semantics. Patrick, could
you please make a call on this?
Patrick McHardy states:
NF_STOLEN should work fine here.
Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'MAINTAINERS')
0 files changed, 0 insertions, 0 deletions