diff options
| author | M A Ramdhan <ramdhan@starlabs.sg> | 2023-07-05 19:15:30 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2023-07-07 05:10:49 +0300 |
| commit | 0323bce598eea038714f941ce2b22541c46d488f (patch) | |
| tree | ad4ddf18f7d87b6201bc62b1d94245cc4a07e8a6 /Kconfig | |
| parent | 525c469e5de9bf7e53574396196e80fc716ac9eb (diff) | |
| download | linux-0323bce598eea038714f941ce2b22541c46d488f.tar.xz | |
net/sched: cls_fw: Fix improper refcount update leads to use-after-free
In the event of a failure in tcf_change_indev(), fw_set_parms() will
immediately return an error after incrementing or decrementing
reference counter in tcf_bind_filter(). If attacker can control
reference counter to zero and make reference freed, leading to
use after free.
In order to prevent this, move the point of possible failure above the
point where the TC_FW_CLASSID is handled.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: M A Ramdhan <ramdhan@starlabs.sg>
Signed-off-by: M A Ramdhan <ramdhan@starlabs.sg>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Reviewed-by: Pedro Tammela <pctammela@mojatatu.com>
Message-ID: <20230705161530.52003-1-ramdhan@starlabs.sg>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'Kconfig')
0 files changed, 0 insertions, 0 deletions