diff options
| author | Alexander Shishkin <alexander.shishkin@linux.intel.com> | 2015-12-22 18:25:21 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-04-03 07:23:22 +0300 |
| commit | ffb2f3f86b3a6e0ef2b9c6f53e1e98931061db9b (patch) | |
| tree | cd736a077c2a7db335036815ff108a5e5f4459fe | |
| parent | 30e94dc24edd8d028da6a02d1a85028ead2f40ed (diff) | |
| download | linux-ffb2f3f86b3a6e0ef2b9c6f53e1e98931061db9b.tar.xz | |
stm class: Prevent user-controllable allocations
[ Upstream commit f08b18266c7116e2ec6885dd53a928f580060a71 ]
Currently, the character device write method allocates a temporary buffer
for user's data, but the user's data size is not sanitized and can cause
arbitrarily large allocations via kzalloc() or an integer overflow that
will then result in overwriting kernel memory.
This patch trims the input buffer size to avoid these issues.
Reported-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/hwtracing/stm/core.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c index f286de2e86af..e4fa583b57a6 100644 --- a/drivers/hwtracing/stm/core.c +++ b/drivers/hwtracing/stm/core.c @@ -410,6 +410,9 @@ static ssize_t stm_char_write(struct file *file, const char __user *buf, char *kbuf; int err; + if (count + 1 > PAGE_SIZE) + count = PAGE_SIZE - 1; + /* * if no m/c have been assigned to this writer up to this * point, use "default" policy entry |