summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIan Abbott <abbotti@mev.co.uk>2014-07-31 17:47:55 +0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-08-16 23:23:09 +0400
commitfe10bdbda634597b4853cd45bc655e1bc8f3d89e (patch)
tree876844e6271c3a844644cb71305a22c753f6f499
parentfd2bb912e17aee18713504d157bceff7f41fad1e (diff)
downloadlinux-fe10bdbda634597b4853cd45bc655e1bc8f3d89e.tar.xz
staging: comedi: amplc_pci224: no need to comedi_set_hw_dev() here
The comedi core module calls `comedi_set_hw_dev()` to associate the hardware `struct device` with the `struct comedi_device` before it calls the comedi driver's "auto_attach" hook `pci224_auto_attach()`. There is no need for `pci224_auto_attach()` to call `comedi_set_hw_dev()` itself, so remove the call. Signed-off-by: Ian Abbott <abbotti@mev.co.uk> Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/comedi/drivers/amplc_pci224.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c b/drivers/staging/comedi/drivers/amplc_pci224.c
index a01504ac0443..0b056cfd0136 100644
--- a/drivers/staging/comedi/drivers/amplc_pci224.c
+++ b/drivers/staging/comedi/drivers/amplc_pci224.c
@@ -1084,8 +1084,6 @@ pci224_auto_attach(struct comedi_device *dev, unsigned long context_model)
if (!devpriv)
return -ENOMEM;
- comedi_set_hw_dev(dev, &pci_dev->dev);
-
ret = comedi_pci_enable(dev);
if (ret)
return ret;