diff options
| author | Jordy Zomer <jordyzomer@google.com> | 2024-11-28 03:32:45 +0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2024-12-02 02:31:19 +0300 |
| commit | fc342cf86e2dc4d2edb0fc2ff5e28b6c7845adb9 (patch) | |
| tree | b649587a1bd1e6251aea937de996bf551cce0853 | |
| parent | e18655cf35a5958fbf4ae9ca3ebf28871a3a1801 (diff) | |
| download | linux-fc342cf86e2dc4d2edb0fc2ff5e28b6c7845adb9.tar.xz | |
ksmbd: fix Out-of-Bounds Read in ksmbd_vfs_stream_read
An offset from client could be a negative value, It could lead
to an out-of-bounds read from the stream_buf.
Note that this issue is coming when setting
'vfs objects = streams_xattr parameter' in ksmbd.conf.
Cc: stable@vger.kernel.org # v5.15+
Reported-by: Jordy Zomer <jordyzomer@google.com>
Signed-off-by: Jordy Zomer <jordyzomer@google.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/smb/server/smb2pdu.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 416f7df4edef..7b6a3952f228 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -6663,6 +6663,10 @@ int smb2_read(struct ksmbd_work *work) } offset = le64_to_cpu(req->Offset); + if (offset < 0) { + err = -EINVAL; + goto out; + } length = le32_to_cpu(req->Length); mincount = le32_to_cpu(req->MinimumCount); |