diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2025-04-29 09:55:20 +0300 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2025-05-07 10:08:13 +0300 |
| commit | fa870e0f3551cfff90c7d0261e8f208a83097946 (patch) | |
| tree | 61e0dd4e9c80d8b0ef04069a30a67061dba7d421 | |
| parent | 46ff4d11f081ef9bc3df3d56f54a10e955dba733 (diff) | |
| download | linux-fa870e0f3551cfff90c7d0261e8f208a83097946.tar.xz | |
genirq/chip: Rework irq_set_irq_type()
Use the new guards to get and lock the interrupt descriptor and tidy up the
code.
Fixup the kernel doc comment while at it.
No functional change.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/all/20250429065421.355673840@linutronix.de
| -rw-r--r-- | kernel/irq/chip.c | 19 |
1 files changed, 6 insertions, 13 deletions
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index 92bf81aeba22..0904886fb2f7 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -54,22 +54,15 @@ int irq_set_chip(unsigned int irq, const struct irq_chip *chip) EXPORT_SYMBOL(irq_set_chip); /** - * irq_set_irq_type - set the irq trigger type for an irq - * @irq: irq number - * @type: IRQ_TYPE_{LEVEL,EDGE}_* value - see include/linux/irq.h + * irq_set_irq_type - set the irq trigger type for an irq + * @irq: irq number + * @type: IRQ_TYPE_{LEVEL,EDGE}_* value - see include/linux/irq.h */ int irq_set_irq_type(unsigned int irq, unsigned int type) { - unsigned long flags; - struct irq_desc *desc = irq_get_desc_buslock(irq, &flags, IRQ_GET_DESC_CHECK_GLOBAL); - int ret = 0; - - if (!desc) - return -EINVAL; - - ret = __irq_set_trigger(desc, type); - irq_put_desc_busunlock(desc, flags); - return ret; + scoped_irqdesc_get_and_buslock(irq, IRQ_GET_DESC_CHECK_GLOBAL) + return __irq_set_trigger(scoped_irqdesc, type); + return -EINVAL; } EXPORT_SYMBOL(irq_set_irq_type); |