diff options
| author | Filipe Manana <fdmanana@suse.com> | 2025-12-12 20:10:10 +0300 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2025-12-17 00:53:15 +0300 |
| commit | f8da41de0bff9eb1d774a7253da0c9f637c4470a (patch) | |
| tree | 05f13ee120f730eb572cd273b5dbfc2ddc7cee95 | |
| parent | 83f59076a1ae6f5c6845d6f7ed3a1a373d883684 (diff) | |
| download | linux-f8da41de0bff9eb1d774a7253da0c9f637c4470a.tar.xz | |
btrfs: do not free data reservation in fallback from inline due to -ENOSPC
If we fail to create an inline extent due to -ENOSPC, we will attempt to
go through the normal COW path, reserve an extent, create an ordered
extent, etc. However we were always freeing the reserved qgroup data,
which is wrong since we will use data. Fix this by freeing the reserved
qgroup data in __cow_file_range_inline() only if we are not doing the
fallback (ret is <= 0).
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/inode.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 6633b3dc9314..c4c370b6aae9 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -673,8 +673,12 @@ out: * it won't count as data extent, free them directly here. * And at reserve time, it's always aligned to page size, so * just free one page here. + * + * If we fallback to non-inline (ret == 1) due to -ENOSPC, then we need + * to keep the data reservation. */ - btrfs_qgroup_free_data(inode, NULL, 0, fs_info->sectorsize, NULL); + if (ret <= 0) + btrfs_qgroup_free_data(inode, NULL, 0, fs_info->sectorsize, NULL); btrfs_free_path(path); btrfs_end_transaction(trans); return ret; |