diff options
| author | Cássio Gabriel <cassiogabrielcontato@gmail.com> | 2026-05-27 15:24:00 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2026-05-27 15:43:20 +0300 |
| commit | f63ad68e18d774a5d15cd7e405ead63f6b322679 (patch) | |
| tree | 06453ee81c16ad3ed8b28b2aca4cb71b24854b1f | |
| parent | 500eb0203cd1a7b8feea0443f5add9a47444a7b2 (diff) | |
| download | linux-f63ad68e18d774a5d15cd7e405ead63f6b322679.tar.xz | |
ASoC: codecs: simple-mux: Fix enum control bounds check
simple_mux_control_put() rejects values greater than e->items, but
enum control values are zero based. For the two-entry mux used by this
driver, valid values are 0 and 1, so value 2 must be rejected as well.
Accepting e->items can store an invalid mux state, pass it to the GPIO
setter, and pass it on to the DAPM mux update path where it is used as
an index into the enum text array.
Use the same >= e->items check used by the ASoC enum helpers.
Fixes: 342fbb7578d1 ("ASoC: add simple-mux")
Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Link: https://patch.msgid.link/20260527-asoc-simple-mux-enum-bounds-v1-1-3f805b9fc671@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/codecs/simple-mux.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/codecs/simple-mux.c b/sound/soc/codecs/simple-mux.c index 069555f35f73..c2f906a3f074 100644 --- a/sound/soc/codecs/simple-mux.c +++ b/sound/soc/codecs/simple-mux.c @@ -51,7 +51,7 @@ static int simple_mux_control_put(struct snd_kcontrol *kcontrol, struct snd_soc_component *c = snd_soc_dapm_to_component(dapm); struct simple_mux *priv = snd_soc_component_get_drvdata(c); - if (ucontrol->value.enumerated.item[0] > e->items) + if (ucontrol->value.enumerated.item[0] >= e->items) return -EINVAL; if (priv->mux == ucontrol->value.enumerated.item[0]) |