diff options
| author | Dmitry Ivanov <dmitrijs.ivanovs@ubnt.com> | 2016-04-06 17:23:18 +0300 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-05-02 20:54:56 +0300 |
| commit | f0c7c896e3b4f661a076c517c42e38bcb846b5c3 (patch) | |
| tree | 6bb29c272e0c7e7ea2de26cde5acd3493b8f55c6 | |
| parent | ee520ba1a9717e1fa6bac4e3099cdea66cc7f0ab (diff) | |
| download | linux-f0c7c896e3b4f661a076c517c42e38bcb846b5c3.tar.xz | |
nl80211: check netlink protocol in socket release notification
commit 8f815cdde3e550e10c2736990d791f60c2ce43eb upstream.
A non-privileged user can create a netlink socket with the same port_id as
used by an existing open nl80211 netlink socket (e.g. as used by a hostapd
process) with a different protocol number.
Closing this socket will then lead to the notification going to nl80211's
socket release notification handler, and possibly cause an action such as
removing a virtual interface.
Fix this issue by checking that the netlink protocol is NETLINK_GENERIC.
Since generic netlink has no notifier chain of its own, we can't fix the
problem more generically.
Fixes: 026331c4d9b5 ("cfg80211/mac80211: allow registering for and sending action frames")
Signed-off-by: Dmitry Ivanov <dima@ubnt.com>
[rewrite commit message]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | net/wireless/nl80211.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 79c3e641581d..cda142009426 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -11156,7 +11156,7 @@ static int nl80211_netlink_notify(struct notifier_block * nb, struct wireless_dev *wdev; struct cfg80211_beacon_registration *reg, *tmp; - if (state != NETLINK_URELEASE) + if (state != NETLINK_URELEASE || notify->protocol != NETLINK_GENERIC) return NOTIFY_DONE; rcu_read_lock(); |