diff options
| author | Chia-I Wu <olvaffe@gmail.com> | 2025-12-04 20:45:45 +0300 |
|---|---|---|
| committer | Steven Price <steven.price@arm.com> | 2025-12-17 18:50:54 +0300 |
| commit | efe24898485c5c831e629d9c6fb9350c35cb576f (patch) | |
| tree | 3d16b52c092fb22a68bce7f756dc63364293bee3 | |
| parent | 97f419848b1db69fc7ea99f385a7d2fa2b2ca454 (diff) | |
| download | linux-efe24898485c5c831e629d9c6fb9350c35cb576f.tar.xz | |
drm/panthor: fix for dma-fence safe access rules
Commit 506aa8b02a8d6 ("dma-fence: Add safe access helpers and document
the rules") details the dma-fence safe access rules. The most common
culprit is that drm_sched_fence_get_timeline_name may race with
group_free_queue.
Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Cc: stable@vger.kernel.org # v6.17+
Signed-off-by: Steven Price <steven.price@arm.com>
Link: https://patch.msgid.link/20251204174545.399059-1-olvaffe@gmail.com
| -rw-r--r-- | drivers/gpu/drm/panthor/panthor_sched.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c index a17b067a0439..0f83e778d89a 100644 --- a/drivers/gpu/drm/panthor/panthor_sched.c +++ b/drivers/gpu/drm/panthor/panthor_sched.c @@ -23,6 +23,7 @@ #include <linux/module.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> +#include <linux/rcupdate.h> #include "panthor_devfreq.h" #include "panthor_device.h" @@ -943,6 +944,9 @@ static void group_release_work(struct work_struct *work) release_work); u32 i; + /* dma-fences may still be accessing group->queues under rcu lock. */ + synchronize_rcu(); + for (i = 0; i < group->queue_count; i++) group_free_queue(group, group->queues[i]); |