summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZichen Xie <zichenxie0106@gmail.com>2024-10-24 00:13:10 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-01-02 12:30:48 +0300
commiteabe5f73aafeb34556e24471cbac075a01a2787e (patch)
treec1e29db006be281ebe9cee58f5b383ed1a270cc6
parent61ddaac44efaaeabee2a186ec368ad58f0866e69 (diff)
downloadlinux-eabe5f73aafeb34556e24471cbac075a01a2787e.tar.xz
mtd: diskonchip: Cast an operand to prevent potential overflow
commit 9b458e8be0d13e81ed03fffa23f8f9b528bbd786 upstream. There may be a potential integer overflow issue in inftl_partscan(). parts[0].size is defined as "uint64_t" while mtd->erasesize and ip->firstUnit are defined as 32-bit unsigned integer. The result of the calculation will be limited to 32 bits without correct casting. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Zichen Xie <zichenxie0106@gmail.com> Cc: stable@vger.kernel.org Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/mtd/nand/raw/diskonchip.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/nand/raw/diskonchip.c b/drivers/mtd/nand/raw/diskonchip.c
index 2068025d5639..594e13a852c4 100644
--- a/drivers/mtd/nand/raw/diskonchip.c
+++ b/drivers/mtd/nand/raw/diskonchip.c
@@ -1098,7 +1098,7 @@ static inline int __init inftl_partscan(struct mtd_info *mtd, struct mtd_partiti
(i == 0) && (ip->firstUnit > 0)) {
parts[0].name = " DiskOnChip IPL / Media Header partition";
parts[0].offset = 0;
- parts[0].size = mtd->erasesize * ip->firstUnit;
+ parts[0].size = (uint64_t)mtd->erasesize * ip->firstUnit;
numparts = 1;
}