diff options
| author | Filipe Manana <fdmanana@suse.com> | 2025-11-13 15:52:45 +0300 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2025-11-25 00:42:24 +0300 |
| commit | e7dd1182fcedee7c6097c9f49eba8de94a4364e3 (patch) | |
| tree | b004500c459e426c60972bc5c91914b39c9a35d0 | |
| parent | 280dd7c106fd4c47756d19f6ae89862bb7bf7225 (diff) | |
| download | linux-e7dd1182fcedee7c6097c9f49eba8de94a4364e3.tar.xz | |
btrfs: fix leaf leak in an error path in btrfs_del_items()
If the call to btrfs_del_leaf() fails we return without decrementing the
extra ref we took on the leaf, therefore leaking it. Fix this by ensuring
we drop the ref count before returning the error.
Fixes: 751a27615dda ("btrfs: do not BUG_ON() on tree mod log failures at btrfs_del_ptr()")
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/ctree.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index f6a9b6bbf78b..614aa4b56571 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@ -4562,9 +4562,9 @@ int btrfs_del_items(struct btrfs_trans_handle *trans, struct btrfs_root *root, if (btrfs_header_nritems(leaf) == 0) { path->slots[1] = slot; ret = btrfs_del_leaf(trans, root, path, leaf); + free_extent_buffer(leaf); if (ret < 0) return ret; - free_extent_buffer(leaf); ret = 0; } else { /* if we're still in the path, make sure |