diff options
| author | Felix Gu <ustc.gu@gmail.com> | 2026-01-27 21:23:12 +0300 |
|---|---|---|
| committer | Linus Walleij <linusw@kernel.org> | 2026-02-03 03:28:59 +0300 |
| commit | e56aa18eba32fb68ac5e19e44670010095bb189c (patch) | |
| tree | 5093fed8bf8c82e1bbcdbfdf7ed7f775345ee639 | |
| parent | eabf273c8466af3f033473c2d2267a6ea7946d57 (diff) | |
| download | linux-e56aa18eba32fb68ac5e19e44670010095bb189c.tar.xz | |
pinctrl: meson: amlogic-a4: Fix device node reference leak in bank helpers
of_parse_phandle_with_fixed_args() increments the reference count of the
returned device node, so it must be explicitly released using
of_node_put() after use.
Fix the reference leak in aml_bank_pins() and aml_bank_number() by
adding the missing of_node_put() calls.
Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
Signed-off-by: Linus Walleij <linusw@kernel.org>
| -rw-r--r-- | drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c index ded7b218e2ec..40542edd557e 100644 --- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c +++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c @@ -725,8 +725,9 @@ static u32 aml_bank_pins(struct device_node *np) if (of_parse_phandle_with_fixed_args(np, "gpio-ranges", 3, 0, &of_args)) return 0; - else - return of_args.args[2]; + + of_node_put(of_args.np); + return of_args.args[2]; } static int aml_bank_number(struct device_node *np) @@ -736,8 +737,9 @@ static int aml_bank_number(struct device_node *np) if (of_parse_phandle_with_fixed_args(np, "gpio-ranges", 3, 0, &of_args)) return -EINVAL; - else - return of_args.args[1] >> 8; + + of_node_put(of_args.np); + return of_args.args[1] >> 8; } static unsigned int aml_count_pins(struct device_node *np) |