summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArvind Yadav <arvind.yadav.cs@gmail.com>2017-11-16 07:27:20 +0300
committerDavid S. Miller <davem@davemloft.net>2017-11-16 16:31:15 +0300
commite17aa09884f88663ba127ea0c0ff69a1b1a87d66 (patch)
tree4bf7eba4c52fe508cbf67c0c13066c8276204144
parentb0927bd98f2bdb5687ff038ee5bb9ecaa7a27dfa (diff)
downloadlinux-e17aa09884f88663ba127ea0c0ff69a1b1a87d66.tar.xz
isdn: hisax: Fix pnp_irq's error checking for setup_diva_isapnp
The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/isdn/hisax/diva.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/isdn/hisax/diva.c b/drivers/isdn/hisax/diva.c
index 38bdd3f7b960..d23df7a7784d 100644
--- a/drivers/isdn/hisax/diva.c
+++ b/drivers/isdn/hisax/diva.c
@@ -1093,7 +1093,7 @@ static int setup_diva_isapnp(struct IsdnCard *card)
}
card->para[1] = pnp_port_start(pnp_d, 0);
card->para[0] = pnp_irq(pnp_d, 0);
- if (!card->para[0] || !card->para[1]) {
+ if (card->para[0] == -1 || !card->para[1]) {
printk(KERN_ERR "Diva PnP:some resources are missing %ld/%lx\n",
card->para[0], card->para[1]);
pnp_disable_dev(pnp_d);