diff options
| author | Roberto Bergantinos Corpas <rbergant@redhat.com> | 2019-05-28 10:38:14 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-06-09 10:18:18 +0300 |
| commit | dea5d380e22c1bd754cd3f02ac75ca544b4f656e (patch) | |
| tree | 9d99a14ddbea09adf5f4d2651b1f8c937e24291d | |
| parent | f205a917143120bd0caceb79f68331ebb59edffb (diff) | |
| download | linux-dea5d380e22c1bd754cd3f02ac75ca544b4f656e.tar.xz | |
CIFS: cifs_read_allocate_pages: don't iterate through whole page array on ENOMEM
commit 31fad7d41e73731f05b8053d17078638cf850fa6 upstream.
In cifs_read_allocate_pages, in case of ENOMEM, we go through
whole rdata->pages array but we have failed the allocation before
nr_pages, therefore we may end up calling put_page with NULL
pointer, causing oops
Signed-off-by: Roberto Bergantinos Corpas <rbergant@redhat.com>
Acked-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
CC: Stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/cifs/file.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 48ea9dfd5f02..6ee8f9270892 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c @@ -2984,7 +2984,9 @@ cifs_read_allocate_pages(struct cifs_readdata *rdata, unsigned int nr_pages) } if (rc) { - for (i = 0; i < nr_pages; i++) { + unsigned int nr_page_failed = i; + + for (i = 0; i < nr_page_failed; i++) { put_page(rdata->pages[i]); rdata->pages[i] = NULL; } |