diff options
| author | Ezequiel Garcia <ezequiel@collabora.com> | 2018-07-26 00:01:23 +0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2018-07-27 14:53:10 +0300 |
| commit | ddc5c1f799123224a8e02c49d992f962bed225f3 (patch) | |
| tree | 7196000ecd196f852daabcfcc2eec8cab0c91023 | |
| parent | 87e1a881e1fe3bfd89903c54ae0d6d6adedb76f1 (diff) | |
| download | linux-ddc5c1f799123224a8e02c49d992f962bed225f3.tar.xz | |
media: rockchip/rga: Fix bad dma_free_attrs() parameter
In rga_remove(), dma_free_attrs is being passed the wrong
cpu address, which triggers an exception if the driver is
removed. Fix it.
Tested on a RK3399 platform, with a bind/unbind cycle.
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
| -rw-r--r-- | drivers/media/platform/rockchip/rga/rga.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c index 69a2797d7bbe..ab5a6f95044a 100644 --- a/drivers/media/platform/rockchip/rga/rga.c +++ b/drivers/media/platform/rockchip/rga/rga.c @@ -925,7 +925,7 @@ static int rga_remove(struct platform_device *pdev) { struct rockchip_rga *rga = platform_get_drvdata(pdev); - dma_free_attrs(rga->dev, RGA_CMDBUF_SIZE, &rga->cmdbuf_virt, + dma_free_attrs(rga->dev, RGA_CMDBUF_SIZE, rga->cmdbuf_virt, rga->cmdbuf_phy, DMA_ATTR_WRITE_COMBINE); free_pages((unsigned long)rga->src_mmu_pages, 3); |