diff options
| author | Chengfeng Ye <cyeaa@connect.ust.hk> | 2021-11-04 16:38:31 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-01-27 11:00:49 +0300 |
| commit | d8002fab3eb47e690a378b459e67d73b95d9c0ef (patch) | |
| tree | bd9ecdf7fda43a48a9755382acdb10eb590b1972 | |
| parent | cde0f1a0a486fb47017ef74e79f31aaf3444fff9 (diff) | |
| download | linux-d8002fab3eb47e690a378b459e67d73b95d9c0ef.tar.xz | |
crypto: qce - fix uaf on qce_ahash_register_one
[ Upstream commit b4cb4d31631912842eb7dce02b4350cbb7562d5e ]
Pointer base points to sub field of tmpl, it
is dereferenced after tmpl is freed. Fix
this by accessing base before free tmpl.
Fixes: ec8f5d8f ("crypto: qce - Qualcomm crypto engine driver")
Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
Acked-by: Thara Gopinath <thara.gopinath@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/crypto/qce/sha.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/crypto/qce/sha.c b/drivers/crypto/qce/sha.c index 47e114ac09d0..ff1e788f9276 100644 --- a/drivers/crypto/qce/sha.c +++ b/drivers/crypto/qce/sha.c @@ -544,8 +544,8 @@ static int qce_ahash_register_one(const struct qce_ahash_def *def, ret = crypto_register_ahash(alg); if (ret) { - kfree(tmpl); dev_err(qce->dev, "%s registration failed\n", base->cra_name); + kfree(tmpl); return ret; } |