diff options
| author | Wenwen Wang <wenwen@cs.uga.edu> | 2019-08-06 10:00:27 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-08-16 11:12:50 +0300 |
| commit | d4d904e4e258e1e5c794af3e702d6f6ecc8fd56d (patch) | |
| tree | 72156589d782e91d75f615bbbcd1e97195782c1e | |
| parent | e0d262a57fc741a9b362e458c714e37a77ddb62d (diff) | |
| download | linux-d4d904e4e258e1e5c794af3e702d6f6ecc8fd56d.tar.xz | |
ALSA: usb-audio: fix a memory leak bug
commit a67060201b746a308b1674f66bf289c9faef6d09 upstream.
In snd_usb_get_audioformat_uac3(), a structure for channel maps 'chmap' is
allocated through kzalloc() before the execution goto 'found_clock'.
However, this structure is not deallocated if the memory allocation for
'pd' fails, leading to a memory leak bug.
To fix the above issue, free 'fp->chmap' before returning NULL.
Fixes: 7edf3b5e6a45 ("ALSA: usb-audio: AudioStreaming Power Domain parsing")
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | sound/usb/stream.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/usb/stream.c b/sound/usb/stream.c index d9e3de495c16..bc582202bd10 100644 --- a/sound/usb/stream.c +++ b/sound/usb/stream.c @@ -1053,6 +1053,7 @@ found_clock: pd = kzalloc(sizeof(*pd), GFP_KERNEL); if (!pd) { + kfree(fp->chmap); kfree(fp->rate_table); kfree(fp); return NULL; |