diff options
| author | Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com> | 2026-01-20 20:47:43 +0300 |
|---|---|---|
| committer | Manivannan Sadhasivam <mani@kernel.org> | 2026-01-21 12:15:32 +0300 |
| commit | d266f63b385a3bad5fd6f23797b6de57de998677 (patch) | |
| tree | c3760b5fdd349e97ab1292537ec797000fc2f898 | |
| parent | 36dd677f7d76ddec96d50cf57f543ba7d612087c (diff) | |
| download | linux-d266f63b385a3bad5fd6f23797b6de57de998677.tar.xz | |
PCI: dwc: Rework the error print of dw_pcie_wait_for_link()
For the cases where the link cannot come up later i.e., when LTSSM is not
in Detect.{Quiet/Active} or Poll.{Active/Compliance} states,
dw_pcie_wait_for_link() should log an error.
So promote dev_info() to dev_err(), reword the error log to make it clear
and also print the LTSSM state to aid debugging.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Tested-by: Richard Zhu <hongxing.zhu@nxp.com>
Tested-by: Vincent Guittot <vincent.guittot@linaro.org>
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
Link: https://patch.msgid.link/20260120-pci-dwc-suspend-rework-v4-4-2f32d5082549@oss.qualcomm.com
| -rw-r--r-- | drivers/pci/controller/dwc/pcie-designware.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c index f74eae79cca4..2fa9f6ee149e 100644 --- a/drivers/pci/controller/dwc/pcie-designware.c +++ b/drivers/pci/controller/dwc/pcie-designware.c @@ -787,7 +787,8 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci) return -EIO; } - dev_info(pci->dev, "Phy link never came up\n"); + dev_err(pci->dev, "Link failed to come up. LTSSM: %s\n", + dw_pcie_ltssm_status_string(ltssm)); return -ETIMEDOUT; } |