diff options
| author | Jiri Olsa <jolsa@kernel.org> | 2026-04-24 18:39:05 +0300 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2026-04-27 20:15:00 +0300 |
| commit | cfeddb4244268c246d67cbe50269a9475cb112fc (patch) | |
| tree | 9fbb665fa9fee20d5342542788547d5aa2320383 | |
| parent | 79b8ebcbe483fee401e1b91dd32470348d9aa5b8 (diff) | |
| download | linux-cfeddb4244268c246d67cbe50269a9475cb112fc.tar.xz | |
bpf: Remove obsolete WARN_ON call
The WARN_ON call in bpf_trampoline_update could never hit, because we
direct the code path with (total == 0) to out label, which effectively
skips the WARN_ON call.
The WARN_ON made sense back then when it checked tr->selector, but now
with total being set just inside the function it's useless.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20260424153905.354922-2-jolsa@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
| -rw-r--r-- | kernel/bpf/trampoline.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/kernel/bpf/trampoline.c b/kernel/bpf/trampoline.c index f02254a21585..a4298a25d4ba 100644 --- a/kernel/bpf/trampoline.c +++ b/kernel/bpf/trampoline.c @@ -685,7 +685,6 @@ again: if (err) goto out_free; - WARN_ON(tr->cur_image && total == 0); if (tr->cur_image) /* progs already running at this address */ err = modify_fentry(tr, orig_flags, tr->cur_image->image, |