summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorManu Abraham <abraham.manu@gmail.com>2007-10-09 02:04:03 +0400
committerMauro Carvalho Chehab <mchehab@redhat.com>2008-12-29 22:53:18 +0300
commitcf6efeb6705e9828291401f890dcb327a0ea52e7 (patch)
tree7eccf311e6b78de7d9945ae91308fa2cc34b036b
parent6199ceef8bd28b79e0792423ca79cce8b224cd50 (diff)
downloadlinux-cf6efeb6705e9828291401f890dcb327a0ea52e7.tar.xz
V4L/DVB (9419): Bug: unnecessary large current causes large phasor errors
Signed-off-by: Manu Abraham <manu@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r--drivers/media/dvb/frontends/tda8261.c13
1 files changed, 12 insertions, 1 deletions
diff --git a/drivers/media/dvb/frontends/tda8261.c b/drivers/media/dvb/frontends/tda8261.c
index 9cbd511d749e..1b9f4dc1b003 100644
--- a/drivers/media/dvb/frontends/tda8261.c
+++ b/drivers/media/dvb/frontends/tda8261.c
@@ -130,6 +130,10 @@ static int tda8261_set_state(struct dvb_frontend *fe,
* (to account for half channel spacing on either side)
*/
frequency = tstate->frequency;
+ if ((frequency < 950000) || (frequency > 2150000)) {
+ printk("%s: Frequency beyond limits, frequency=%d\n", __func__, frequency);
+ return -EINVAL;
+ }
N = (frequency + (div_tab[config->step_size] - 1)) / div_tab[config->step_size];
printk("%s: Step size=%d, Divider=%d, PG=0x%02x (%d)\n",
__func__, config->step_size, div_tab[config->step_size], N, N);
@@ -137,7 +141,14 @@ static int tda8261_set_state(struct dvb_frontend *fe,
buf[0] = (N >> 8) & 0xff;
buf[1] = N & 0xff;
buf[2] = (0x01 << 7) | ((ref_div[config->step_size] & 0x07) << 1);
- buf[3] = 0xc0;
+
+ if (frequency < 1450000)
+ buf[3] = 0x00;
+ if (frequency < 2000000)
+ buf[3] = 0x40;
+ if (frequency < 2150000)
+ buf[3] = 0x80;
+
/* Set params */
if ((err = tda8261_write(state, buf)) < 0) {
printk("%s: I/O Error\n", __func__);