diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2017-11-16 13:22:26 +0300 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2017-11-29 11:29:41 +0300 |
| commit | cf576fe5fd74cdabf7fc3fd8ac3b9abea9b964f8 (patch) | |
| tree | 5737ae8d93b78051547560d4f02a38b60d908879 | |
| parent | 4d0272ca40dfe524ce8d1ae350f0a246ef849d4b (diff) | |
| download | linux-cf576fe5fd74cdabf7fc3fd8ac3b9abea9b964f8.tar.xz | |
ALSA: korg1212: Delete a duplicate function call "release_firmware" in snd_korg1212_create()
The function "release_firmware" is called in the current implementation of
the function "_request_firmware" after a failure was detected.
Link: https://elixir.free-electrons.com/linux/v4.14-rc8/source/drivers/base/firmware_class.c#L1196
Such a call should therefore not be repeated directly after the
corresponding error information was received in the local variable "err"
of the function "snd_korg1212_create".
Thus remove a misplaced function call.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/pci/korg1212/korg1212.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/sound/pci/korg1212/korg1212.c b/sound/pci/korg1212/korg1212.c index c7b007164c99..4206ba44d8bb 100644 --- a/sound/pci/korg1212/korg1212.c +++ b/sound/pci/korg1212/korg1212.c @@ -2348,7 +2348,6 @@ static int snd_korg1212_create(struct snd_card *card, struct pci_dev *pci, err = request_firmware(&dsp_code, "korg/k1212.dsp", &pci->dev); if (err < 0) { - release_firmware(dsp_code); snd_printk(KERN_ERR "firmware not available\n"); snd_korg1212_free(korg1212); return err; |