diff options
| author | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-04-17 10:13:38 +0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-04-17 10:21:47 +0300 |
| commit | ceab3ac1e60d70afb4e25147d60817c513f235f7 (patch) | |
| tree | c0d7bd416f08a09d0aeaa5f093d7a606b3c71bf0 | |
| parent | a735e6b80d911fc1f452cea328c61779445e1054 (diff) | |
| download | linux-ceab3ac1e60d70afb4e25147d60817c513f235f7.tar.xz | |
media: dvb-frontends: DUMMY_FE should depends on DVB_CORE
Using select for DVB_CORE doesn't work, as reported by
Randy:
CONFIG_I2C=m
CONFIG_DVB_CORE=y
ld: drivers/media/dvb-core/dvbdev.o: in function `dvb_module_probe':
dvbdev.c:(.text+0xf92): undefined reference to `i2c_new_client_device'
ld: dvbdev.c:(.text+0xffb): undefined reference to `i2c_unregister_device'
ld: drivers/media/dvb-core/dvbdev.o: in function `dvb_module_release':
dvbdev.c:(.text+0x107d): undefined reference to `i2c_unregister_device'
The problem is actually caused by the dummy frontend driver,
which uses select, and it is missing an I2C dependency:
WARNING: unmet direct dependencies detected for DVB_CORE
Depends on [m]: MEDIA_SUPPORT [=y] && MEDIA_DIGITAL_TV_SUPPORT [=y] && (I2C [=m] || I2C [=m]=n)
Selected by [y]:
- DVB_DUMMY_FE [=y] && MEDIA_SUPPORT [=y] && MEDIA_TEST_SUPPORT [=y]
As this is the only frontend driver using "select DVB_CORE",
change it do depends on DVB_CORE.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
| -rw-r--r-- | drivers/media/dvb-frontends/Kconfig | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/media/dvb-frontends/Kconfig b/drivers/media/dvb-frontends/Kconfig index fbadba9b328e..643b851a6b60 100644 --- a/drivers/media/dvb-frontends/Kconfig +++ b/drivers/media/dvb-frontends/Kconfig @@ -956,7 +956,6 @@ comment "Tools to develop new frontends" config DVB_DUMMY_FE tristate "Dummy frontend driver" - depends on MEDIA_TEST_SUPPORT - select DVB_CORE + depends on MEDIA_TEST_SUPPORT && DVB_CORE help Dummy skeleton frontend driver. |