diff options
| author | Qasim Ijaz <qasdev00@gmail.com> | 2025-04-21 14:25:44 +0300 |
|---|---|---|
| committer | Felix Fietkau <nbd@nbd.name> | 2025-05-21 15:49:39 +0300 |
| commit | cb423ddad0f6e6f55b1700422ab777b25597cc83 (patch) | |
| tree | fcdbcc5335af20da9489bbb4bb36876f8562ab40 | |
| parent | 7011faebe543f8f094fdb3281d0ec9e1eab81309 (diff) | |
| download | linux-cb423ddad0f6e6f55b1700422ab777b25597cc83.tar.xz | |
wifi: mt76: mt7996: avoid NULL pointer dereference in mt7996_set_monitor()
The function mt7996_set_monitor() dereferences phy before
the NULL sanity check.
Fix this to avoid NULL pointer dereference by moving the
dereference after the check.
Fixes: 69d54ce7491d ("wifi: mt76: mt7996: switch to single multi-radio wiphy")
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
Link: https://patch.msgid.link/20250421112544.13430-1-qasdev00@gmail.com
Signed-off-by: Felix Fietkau <nbd@nbd.name>
| -rw-r--r-- | drivers/net/wireless/mediatek/mt76/mt7996/main.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/main.c b/drivers/net/wireless/mediatek/mt76/mt7996/main.c index 70823bbb165c..5ec4f9793286 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7996/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7996/main.c @@ -414,11 +414,13 @@ static void mt7996_phy_set_rxfilter(struct mt7996_phy *phy) static void mt7996_set_monitor(struct mt7996_phy *phy, bool enabled) { - struct mt7996_dev *dev = phy->dev; + struct mt7996_dev *dev; if (!phy) return; + dev = phy->dev; + if (enabled == !(phy->rxfilter & MT_WF_RFCR_DROP_OTHER_UC)) return; |