diff options
| author | Ian Abbott <abbotti@mev.co.uk> | 2025-04-15 14:35:56 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-04-25 16:53:18 +0300 |
| commit | cb0dde4d058b1fe7fc80d851b16c6687f461214b (patch) | |
| tree | bcc4ca45f7eb2094b605e4a13be0a2f54aacdfb9 | |
| parent | a7924f4c489bb6a3f28850f13eaa3e1d2747d0fb (diff) | |
| download | linux-cb0dde4d058b1fe7fc80d851b16c6687f461214b.tar.xz | |
comedi: ni_pcidio: Do not bother filling buffer with 0xaa byte values
On buffer change, the driver informs the mite module about the buffer
change and then it fills the buffer with byte value `0xaa` using
`memset()`. Do not bother filling the buffer. None of the other Comedi
drivers do this.
The aim is to get rid of the `prealloc_buf` member of `struct
comedi_async` (which is from a `vmap()` covering the whole buffer in
those Comedi drivers that do not use DMA), and use the per-buffer-page
addresses from the `virt_addr` member of `struct comedi_buf_page` to
access the buffer contents instead.
(If necessary, we could add a `comedi_buf_memset()` function to fill the
buffer with a byte value, but it's not worth it in this case.)
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/20250415114008.5977-2-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/comedi/drivers/ni_pcidio.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/comedi/drivers/ni_pcidio.c b/drivers/comedi/drivers/ni_pcidio.c index 2d58e83420e8..2c7bb9c1ea5b 100644 --- a/drivers/comedi/drivers/ni_pcidio.c +++ b/drivers/comedi/drivers/ni_pcidio.c @@ -747,8 +747,6 @@ static int ni_pcidio_change(struct comedi_device *dev, if (ret < 0) return ret; - memset(s->async->prealloc_buf, 0xaa, s->async->prealloc_bufsz); - return 0; } |