diff options
| author | Alexander Aring <aahringo@redhat.com> | 2022-06-22 21:45:13 +0300 |
|---|---|---|
| committer | David Teigland <teigland@redhat.com> | 2022-06-24 19:57:40 +0300 |
| commit | ca8031d917691e5c4f101c9ec39fc41b105b7e14 (patch) | |
| tree | ef76519c0ec46283408991fec76febd06810402c | |
| parent | 5d92a30e900dc97221e36f09ae740457d560d281 (diff) | |
| download | linux-ca8031d917691e5c4f101c9ec39fc41b105b7e14.tar.xz | |
fs: dlm: update comments about recovery and membership handling
Make clear that a particular recovery iteration must not be aborted
before membership changes are applied to the members list (ls_nodes)
and midcomms layer. Interrupting recovery before this can result
in missing node-specific changes in midcomms or through lsops.
Signed-off-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: David Teigland <teigland@redhat.com>
| -rw-r--r-- | fs/dlm/member.c | 6 | ||||
| -rw-r--r-- | fs/dlm/recoverd.c | 4 |
2 files changed, 9 insertions, 1 deletions
diff --git a/fs/dlm/member.c b/fs/dlm/member.c index 98084e0cfccf..7e5f5aefefb5 100644 --- a/fs/dlm/member.c +++ b/fs/dlm/member.c @@ -534,7 +534,11 @@ int dlm_recover_members(struct dlm_ls *ls, struct dlm_recover *rv, int *neg_out) int i, error, neg = 0, low = -1; /* previously removed members that we've not finished removing need to - count as a negative change so the "neg" recovery steps will happen */ + * count as a negative change so the "neg" recovery steps will happen + * + * This functionality must report all member changes to lsops or + * midcomms layer and must never return before. + */ list_for_each_entry(memb, &ls->ls_nodes_gone, list) { log_rinfo(ls, "prev removed member %d", memb->nodeid); diff --git a/fs/dlm/recoverd.c b/fs/dlm/recoverd.c index a55dfce705dd..2d46e65d0101 100644 --- a/fs/dlm/recoverd.c +++ b/fs/dlm/recoverd.c @@ -70,6 +70,10 @@ static int ls_recover(struct dlm_ls *ls, struct dlm_recover *rv) /* * Add or remove nodes from the lockspace's ls_nodes list. + * + * Due to the fact that we must report all membership changes to lsops + * or midcomms layer, it is not permitted to abort ls_recover() until + * this is done. */ error = dlm_recover_members(ls, rv, &neg); |