diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2025-08-30 21:43:16 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-09-03 02:09:36 +0300 |
| commit | c2e5108649ab8dec599d074b7ea344e61efa5eee (patch) | |
| tree | fb16f43de0fa077313fe6031ba5b3a6d1c91d111 | |
| parent | 5d14bbf9d1d90cb7ca3e46fe2c8a4277572eab94 (diff) | |
| download | linux-c2e5108649ab8dec599d074b7ea344e61efa5eee.tar.xz | |
selftests: drv-net: adjust tests before defaulting to shell=False
Clean up tests which expect shell=True without explicitly passing
that param to cmd(). There seems to be only one such case, and
in fact it's better converted to a direct write.
Reviewed-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20250830184317.696121-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rwxr-xr-x | tools/testing/selftests/drivers/net/napi_threaded.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/testing/selftests/drivers/net/napi_threaded.py b/tools/testing/selftests/drivers/net/napi_threaded.py index ed66efa481b0..f4be72b2145a 100755 --- a/tools/testing/selftests/drivers/net/napi_threaded.py +++ b/tools/testing/selftests/drivers/net/napi_threaded.py @@ -24,7 +24,8 @@ def _assert_napi_threaded_disabled(nl, napi_id) -> None: def _set_threaded_state(cfg, threaded) -> None: - cmd(f"echo {threaded} > /sys/class/net/{cfg.ifname}/threaded") + with open(f"/sys/class/net/{cfg.ifname}/threaded", "wb") as fp: + fp.write(str(threaded).encode('utf-8')) def _setup_deferred_cleanup(cfg) -> None: |