diff options
| author | Johan Hovold <johan@kernel.org> | 2025-11-21 19:42:01 +0300 |
|---|---|---|
| committer | Thierry Reding <treding@nvidia.com> | 2026-01-14 17:23:17 +0300 |
| commit | bfef062695570842cf96358f2f46f4c6642c6689 (patch) | |
| tree | 422932be33c0afab18c39b5d06b3fd13624a9c62 | |
| parent | cd98e73492102a2ff54923f08c37a2780979ac4c (diff) | |
| download | linux-bfef062695570842cf96358f2f46f4c6642c6689.tar.xz | |
drm/tegra: dsi: fix device leak on probe
Make sure to drop the reference taken when looking up the companion
(ganged) device and its driver data during probe().
Note that holding a reference to a device does not prevent its driver
data from going away so there is no point in keeping the reference.
Fixes: e94236cde4d5 ("drm/tegra: dsi: Add ganged mode support")
Fixes: 221e3638feb8 ("drm/tegra: Fix reference leak in tegra_dsi_ganged_probe")
Cc: stable@vger.kernel.org # 3.19: 221e3638feb8
Cc: Thierry Reding <treding@nvidia.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Link: https://patch.msgid.link/20251121164201.13188-1-johan@kernel.org
| -rw-r--r-- | drivers/gpu/drm/tegra/dsi.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index 175f5f9937b0..8ee96b59fdbc 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/dsi.c @@ -1542,11 +1542,9 @@ static int tegra_dsi_ganged_probe(struct tegra_dsi *dsi) return -EPROBE_DEFER; dsi->slave = platform_get_drvdata(gangster); - - if (!dsi->slave) { - put_device(&gangster->dev); + put_device(&gangster->dev); + if (!dsi->slave) return -EPROBE_DEFER; - } dsi->slave->master = dsi; } |