diff options
| author | George Spelvin <linux@horizon.com> | 2013-03-27 17:08:33 +0400 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2013-03-28 20:10:24 +0400 |
| commit | b949be5857a4033e00fed67b707774f52619ce60 (patch) | |
| tree | 2463a095f1227887320872fe298a1a1f3c2250a9 | |
| parent | 29177b896676496dbefa27bd35f19c64e47cf0d3 (diff) | |
| download | linux-b949be5857a4033e00fed67b707774f52619ce60.tar.xz | |
idr: document exit conditions on idr_for_each_entry better
And some manual common subexpression elimination which may help the
compiler produce smaller code.
Signed-off-by: George Spelvin <linux@horizon.com>
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | include/linux/idr.h | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/include/linux/idr.h b/include/linux/idr.h index 2640c7e99e51..6ece0583362a 100644 --- a/include/linux/idr.h +++ b/include/linux/idr.h @@ -122,11 +122,13 @@ static inline void *idr_find(struct idr *idr, int id) * @idp: idr handle * @entry: the type * to use as cursor * @id: id entry's key + * + * @entry and @id do not need to be initialized before the loop, and + * after normal terminatinon @entry is left with the value NULL. This + * is convenient for a "not found" value. */ -#define idr_for_each_entry(idp, entry, id) \ - for (id = 0, entry = (typeof(entry))idr_get_next((idp), &(id)); \ - entry != NULL; \ - ++id, entry = (typeof(entry))idr_get_next((idp), &(id))) +#define idr_for_each_entry(idp, entry, id) \ + for (id = 0; ((entry) = idr_get_next(idp, &(id))) != NULL; ++id) /* * Don't use the following functions. These exist only to suppress |