diff options
| author | David Howells <dhowells@redhat.com> | 2024-12-16 23:41:02 +0300 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2024-12-21 00:34:04 +0300 |
| commit | b49194da2aff2c879dec9c59ef8dec0f2b0809ef (patch) | |
| tree | c209c77eec3f500a3043c88bf10b087cac2e0214 | |
| parent | 6e0b503dc65c89b83fbfafb4dac5201c844da1de (diff) | |
| download | linux-b49194da2aff2c879dec9c59ef8dec0f2b0809ef.tar.xz | |
afs: Fix EEXIST error returned from afs_rmdir() to be ENOTEMPTY
AFS servers pass back a code indicating EEXIST when they're asked to remove
a directory that is not empty rather than ENOTEMPTY because not all the
systems that an AFS server can run on have the latter error available and
AFS preexisted the addition of that error in general.
Fix afs_rmdir() to translate EEXIST to ENOTEMPTY.
Fixes: 260a980317da ("[AFS]: Add "directory write" support.")
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/20241216204124.3752367-13-dhowells@redhat.com
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
| -rw-r--r-- | fs/afs/dir.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/fs/afs/dir.c b/fs/afs/dir.c index ada363af5aab..50edd1cae28a 100644 --- a/fs/afs/dir.c +++ b/fs/afs/dir.c @@ -1472,7 +1472,12 @@ static int afs_rmdir(struct inode *dir, struct dentry *dentry) op->file[1].vnode = vnode; } - return afs_do_sync_operation(op); + ret = afs_do_sync_operation(op); + + /* Not all systems that can host afs servers have ENOTEMPTY. */ + if (ret == -EEXIST) + ret = -ENOTEMPTY; + return ret; error: return afs_put_operation(op); |