diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2024-06-30 23:08:40 +0300 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2024-06-30 23:15:26 +0300 |
| commit | b3e992f69c239b0eb99c408c1ca9cd4253d2e7ad (patch) | |
| tree | e1d996866205dd0e241dfac27a55f41d8e42b106 | |
| parent | c98cf41dfbab71e3c6d71061c182fafde0bf0f99 (diff) | |
| download | linux-b3e992f69c239b0eb99c408c1ca9cd4253d2e7ad.tar.xz | |
hwmon: (jc42) Strengthen detect function
Configuration register bit 5 must read 0 for all JC42.4 compliant chips.
Several capability register bits must be set for all TSE2004 compliant
chips. Use that information to strengthen the detect function.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/jc42.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c index 1180af1b1638..a260cff750a5 100644 --- a/drivers/hwmon/jc42.c +++ b/drivers/hwmon/jc42.c @@ -413,7 +413,11 @@ static int jc42_detect(struct i2c_client *client, struct i2c_board_info *info) if (cap < 0 || config < 0 || manid < 0 || devid < 0) return -ENODEV; - if ((cap & 0xff00) || (config & 0xf800)) + if ((cap & 0xff00) || (config & 0xf820)) + return -ENODEV; + + if ((devid & TSE2004_DEVID_MASK) == TSE2004_DEVID && + (cap & 0x00e7) != 0x00e7) return -ENODEV; for (i = 0; i < ARRAY_SIZE(jc42_chips); i++) { |