diff options
| author | Jens Axboe <axboe@kernel.dk> | 2025-01-07 21:07:47 +0300 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2025-01-10 17:51:48 +0300 |
| commit | b08e02045002e0412441d5243b0ee1a9bfc3952b (patch) | |
| tree | 7686241ef8a694052995ea57785d4af054fa3cc3 | |
| parent | d803d123948feffbd992213e144df224097f82b0 (diff) | |
| download | linux-b08e02045002e0412441d5243b0ee1a9bfc3952b.tar.xz | |
io_uring/rw: don't gate retry on completion context
nvme multipath reports that they see spurious -EAGAIN bubbling back to
userspace, which is caused by how they handle retries internally through
a kworker. However, any data that needs preserving or importing for
a read/write request has always been done so at prep time, and we can
sanely skip this check.
Reported-by: "Haeuptle, Michael" <michael.haeuptle@hpe.com>
Link: https://lore.kernel.org/io-uring/DS7PR84MB31105C2C63CFA47BE8CBD6EE95102@DS7PR84MB3110.NAMPRD84.PROD.OUTLOOK.COM/
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | io_uring/rw.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/io_uring/rw.c b/io_uring/rw.c index c52c0515f0a2..ee5d38db9b48 100644 --- a/io_uring/rw.c +++ b/io_uring/rw.c @@ -475,12 +475,6 @@ static bool io_rw_should_reissue(struct io_kiocb *req) */ if (percpu_ref_is_dying(&ctx->refs)) return false; - /* - * Play it safe and assume not safe to re-import and reissue if we're - * not in the original thread group (or in task context). - */ - if (!same_thread_group(req->tctx->task, current) || !in_task()) - return false; io_meta_restore(io, &rw->kiocb); iov_iter_restore(&io->iter, &io->iter_state); |