diff options
| author | Vicki Pfau <vi@endrift.com> | 2025-02-05 06:55:29 +0300 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.com> | 2025-02-07 16:27:48 +0300 |
| commit | b051ffa2aeb2a60e092387b6fb2af1ad42f51a3c (patch) | |
| tree | 620e39e850dc31419dad764e3ad9d1ff5db1de43 | |
| parent | 79504249d7e27cad4a3eeb9afc6386e418728ce0 (diff) | |
| download | linux-b051ffa2aeb2a60e092387b6fb2af1ad42f51a3c.tar.xz | |
HID: hid-steam: Don't use cancel_delayed_work_sync in IRQ context
Lockdep reported that, as steam_do_deck_input_event is called from
steam_raw_event inside of an IRQ context, it can lead to issues if that IRQ
occurs while the work to be cancelled is running. By using cancel_delayed_work,
this issue can be avoided. The exact ordering of the work and the event
processing is not super important, so this is safe.
Fixes: cd438e57dd05 ("HID: hid-steam: Add gamepad-only mode switched to by holding options")
Signed-off-by: Vicki Pfau <vi@endrift.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
| -rw-r--r-- | drivers/hid/hid-steam.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c index 5a17714fedea..c9e65e9088b3 100644 --- a/drivers/hid/hid-steam.c +++ b/drivers/hid/hid-steam.c @@ -1617,7 +1617,7 @@ static void steam_do_deck_input_event(struct steam_device *steam, if (!(b9 & BIT(6)) && steam->did_mode_switch) { steam->did_mode_switch = false; - cancel_delayed_work_sync(&steam->mode_switch); + cancel_delayed_work(&steam->mode_switch); } else if (!steam->client_opened && (b9 & BIT(6)) && !steam->did_mode_switch) { steam->did_mode_switch = true; schedule_delayed_work(&steam->mode_switch, 45 * HZ / 100); |